Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vault-monitoring): Remove labels #1302

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix(vault-monitoring): Remove labels #1302

merged 1 commit into from
Aug 21, 2024

Conversation

isantospardo
Copy link
Contributor

Description

fix vault monitoring prometheusrules, remove labels

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 21, 2024
@isantospardo
fix(vault-monitoring): Remove labels
1ab1256 
Signed-off-by: Iago Santos Pardo <iago.santos.pardo@adfinis.com>
@isantospardo isantospardo marked this pull request as ready for review August 21, 2024 14:33
@isantospardo isantospardo requested review from pree, eyenx and a team as code owners August 21, 2024 14:33
@isantospardo isantospardo merged commit 810429d into main Aug 21, 2024
3 checks passed
@isantospardo isantospardo deleted the fix/vault-metrics-labels branch August 21, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hairmare hairmare hairmare approved these changes

@pree pree Awaiting requested review from pree pree is a code owner

@eyenx eyenx Awaiting requested review from eyenx eyenx is a code owner

@vmaillot vmaillot Awaiting requested review from vmaillot vmaillot is a code owner automatically assigned from adfinis/helm-charts

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isantospardo @hairmare