Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infra-apps): update argo-cd from 4.10 to 5.4 #780

Merged

Conversation

hairmare
Copy link
Contributor

@hairmare hairmare commented Sep 12, 2022

Description

Updates the Argo CD Helm chart from 4.10 to 5.4. The changes are summarized below.

The most important change that affects us is the one leading to the 5.x release. YOu can check if you need to do anything with the following steps:

  • Check if kubectl -n infra-argocd get deployments returns argocd-server, if it does this deployment will change it to a StatefulSet for HA purposes.
  • Check if configs.repositories is set, if it is, some manual intervention will be needed
  • Check if configs.repositoryCredentials is set, if it is, some manual intervention will be needed
  • Check if server.additionalApplications or server.additionalProjects are used, if they are, intervention is needed. I will prepare a follow-up PR that prepares to use argocd-apps in cases where we are affected.

A complete list of the changes may be found in the README: https://github.com/argoproj/argo-helm/tree/main/charts/argo-cd#upgrading

Issues

5.0

5.1

5.2

5.3

5.4

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 12, 2022
@hairmare hairmare marked this pull request as ready for review September 12, 2022 13:41
@hairmare hairmare requested a review from a team as a code owner September 12, 2022 13:41
@hairmare hairmare force-pushed the feat/infra-apps/update-argocd-from-4.10-to-5.4 branch from 2235f20 to 56e314f Compare September 12, 2022 19:38
Copy link
Member

@eyenx eyenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create an issue on our board for this. especially the repositorysecrets are used here and there.

@hairmare hairmare force-pushed the feat/infra-apps/update-argocd-from-4.10-to-5.4 branch from 56e314f to 7b91dbb Compare September 16, 2022 09:11
@eyenx
Copy link
Member

eyenx commented Sep 19, 2022

Fixes #788

@hairmare
Copy link
Contributor Author

I've also started to prepare some internal docs.

Please reach out if you run into any issues with this update.

@hairmare hairmare force-pushed the feat/infra-apps/update-argocd-from-4.10-to-5.4 branch from 7b91dbb to e82c1cd Compare September 19, 2022 11:13
@hairmare hairmare enabled auto-merge (squash) September 19, 2022 11:14
@hairmare hairmare merged commit aaa97e8 into adfinis:main Sep 19, 2022
@hairmare hairmare deleted the feat/infra-apps/update-argocd-from-4.10-to-5.4 branch September 19, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 5.4.4 of argocd is available!
2 participants