Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ebmber): add links from interest to identity #992

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Conversation

Yelinz
Copy link
Member

@Yelinz Yelinz commented Jan 4, 2024

add interest acceptance test

interest disclaimer
image

@Yelinz Yelinz requested a review from derrabauke January 4, 2024 13:57
@Yelinz Yelinz self-assigned this Jan 4, 2024
Copy link
Contributor

@derrabauke derrabauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@open-dynaMIX open-dynaMIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉

One thing tho: The disclaimer should only be visible on the profile page, not on the identity page.

@open-dynaMIX
Copy link
Member

One thing tho: The disclaimer should only be visible on the profile page, not on the identity page.

Works now, thanks!

Another thing I've just noticed: The interest link should only be available for staff and admins. Unpriviliged users don't have access to the identity list view.

@open-dynaMIX open-dynaMIX merged commit 75d446a into main Jan 5, 2024
12 checks passed
@open-dynaMIX open-dynaMIX deleted the interest-link branch January 5, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants