Feat add spinner to output #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
decidedly still can't quite understand the logic of the tests with phpunit. My tests all messed up 😥😓😭😭 |
|
@dimtrovich thank you very much i think spinner needs to be asynchronous, is it possible with current implementation? progress bar is when we know how many items we have to process already so we can know exact progress to show the bar. spinner is when we don't know that in advance so we just let it spin, perform some long task that take arbitrary time, then on finish stop spinner. that means there is no percentage in spinner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposal of a spinner for the output following an issue.
see adhocore/tusc.sh#3 (comment)