chore: improve erro log (#118)

.codecov.yml

@@ -2,6 +2,6 @@ coverage:
   status:
     project:
       default:
-        target: "78%"
+        target: "80.5%"
     patch:
       enabled: false

.github/workflows/build.yml

@@ -1,15 +1,17 @@
 name: Build
 
-on: [push, pull_request]
+on: pull_request
 
 jobs:
   build:
-
+    concurrency:
+      group: monorepo-plugin-${{ github.ref }}
+      cancel-in-progress: true
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-go@v2
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v3
         with:
           go-version: '^1.17.2'
 

CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.5.1]
+
+### Changed
+- Improve error logging by @adikari in https://github.com/monebag/monorepo-diff-buildkite-plugin/pull/118
+
 ## [2.5.0]
 
 ### Fixed

README.md

@@ -18,7 +18,7 @@ If the version number is not provided then the most recent version of the plugin
 steps:
   - label: "Triggering pipelines"
     plugins:
-      - monebag/monorepo-diff#v2.5.0:
+      - monebag/monorepo-diff#v2.5.1:
           diff: "git diff --name-only HEAD~1"
           watch:
             - path: "bar-service/"
@@ -35,7 +35,7 @@ steps:
 steps:
   - label: "Triggering pipelines"
     plugins:
-      - monebag/monorepo-diff#v2.5.0:
+      - monebag/monorepo-diff#v2.5.1:
           diff: "git diff --name-only $(head -n 1 last_successful_build)"
           interpolation: false
           env:
@@ -131,7 +131,7 @@ Add `log_level` property to set the log level. Supported log levels are `debug`
 steps:
   - label: "Triggering pipelines"
     plugins:
-      - monebag/monorepo-diff#v2.5.0:
+      - monebag/monorepo-diff#v2.5.1:
           diff: "git diff --name-only HEAD~1"
           log_level: "debug" # defaults to "info"
           watch:
@@ -207,7 +207,7 @@ hooks:
 steps:
   - label: "Triggering pipelines"
     plugins:
-      - monebag/monorepo-diff#v2.5.0:
+      - monebag/monorepo-diff#v2.5.1:
           diff: "git diff --name-only HEAD~1"
           watch:
             - path: app/cms/

main.go

@@ -22,11 +22,12 @@ func setupLogger(logLevel string) {
 var Version string
 
 func main() {
-	log.Infof("--- :one: monorepo-diff %s", Version)
+	log.Infof("--- running monorepo-diff %s", Version)
 
 	plugin, err := initializePlugin(env("BUILDKITE_PLUGINS", ""))
 
 	if err != nil {
+		log.Debug(err)
 		log.Fatal(err)
 	}
 

plugin.go

@@ -79,6 +79,8 @@ func (s Step) MarshalYAML() (interface{}, error) {
 }
 
 func initializePlugin(data string) (Plugin, error) {
+	log.Debugf("parsing plugin config: %v", data)
+
 	var pluginConfigs []map[string]json.RawMessage
 
 	if err := json.Unmarshal([]byte(data), &pluginConfigs); err != nil {

plugin_test.go

@@ -37,9 +37,10 @@ func TestPluginShouldHaveDefaultValues(t *testing.T) {
 
 func TestPluginWithValidParameter(t *testing.T) {
 	param := ""
-	got, _ := initializePlugin(param)
+	got, err := initializePlugin(param)
 	expected := Plugin{}
 
+	assert.EqualError(t, err, "failed to parse plugin configuration")
 	assert.Equal(t, expected, got)
 }
 

tests/command.bats

@@ -186,9 +186,9 @@ EOM
 
   assert_success
 
-  assert_output --partial "--- :one: monorepo-diff"
-  assert_output --partial "Running diff command: echo foo-service/"
-  assert_output --partial "Output from diff: \nfoo-service/"
+  assert_output --partial "--- running monorepo-diff"
+  assert_output --partial "Running diff command: echo foo-service/ \nbat-service/"
+  assert_output --partial "Output from diff: \nfoo-service/ \nbat-service/"
 
   assert_output --partial << EOM
 steps: