fix: Add custom all value to notification dashboard

Shows bugged exported services as for example "null"
adinhodovic · Nov 7, 2023 · 055a0c3 · 055a0c3
1 parent cf6eae2
commit 055a0c3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/dashboards/argo-cd-notifications.libsonnet b/dashboards/argo-cd-notifications.libsonnet
@@ -50,7 +50,7 @@ local tsLegend = tsOptions.legend;
       query.withSort(1) +
       query.generalOptions.withLabel('Job') +
       query.selectionOptions.withMulti(true) +
-      query.selectionOptions.withIncludeAll(true) +
+      query.selectionOptions.withIncludeAll(true, '.*') +
       query.refresh.onLoad() +
       query.refresh.onTime(),
 
@@ -85,7 +85,7 @@ local tsLegend = tsOptions.legend;
           increase(
             argocd_notifications_deliveries_total{
               %s
-              exported_service =~"$exported_service",
+              exported_service=~"$exported_service",
             }[$__rate_interval]
           )
         )

diff --git a/dashboards_out/argo-cd-notifications-overview.json b/dashboards_out/argo-cd-notifications-overview.json
@@ -51,7 +51,7 @@
                   "type": "prometheus",
                   "uid": "$datasource"
                },
-               "expr": "sum(\n  round(\n    increase(\n      argocd_notifications_deliveries_total{\n        namespace=~'$namespace',\njob=~'$job',\n\n        exported_service =~\"$exported_service\",\n      }[$__rate_interval]\n    )\n  )\n) by (job, exported_service, succeeded)\n",
+               "expr": "sum(\n  round(\n    increase(\n      argocd_notifications_deliveries_total{\n        namespace=~'$namespace',\njob=~'$job',\n\n        exported_service=~\"$exported_service|\",\n      }[$__rate_interval]\n    )\n  )\n) by (job, exported_service, succeeded)\n",
                "legendFormat": "{{ exported_service }} - Succeeded: {{ succeeded }}"
             }
          ],
@@ -138,6 +138,7 @@
             "type": "query"
          },
          {
+            "allValue": ".*",
             "datasource": {
                "type": "prometheus",
                "uid": "${datasource}"