more comments

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
adisuissa · Jan 10, 2024 · e66b0c6 · e66b0c6
1 parent 1972625
commit e66b0c6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/source/common/upstream/edf_scheduler.h b/source/common/upstream/edf_scheduler.h
@@ -148,8 +148,9 @@ template <class C> class EdfScheduler : public Scheduler<C> {
     // Left to do some picks, execute them one after the other.
     EDF_TRACE("Emulated {} picks in init step, {} picks remaining for one after the other step",
               picks_so_far, picks - picks_so_far);
-    for (; picks_so_far < picks; ++picks_so_far) {
+    while (picks_so_far < picks) {
       scheduler.pickAndAdd(calculate_weight);
+      picks_so_far++;
     }
     return scheduler;
   }

diff --git a/test/common/upstream/edf_scheduler_test.cc b/test/common/upstream/edf_scheduler_test.cc
@@ -172,7 +172,7 @@ TEST_F(EdfSchedulerTest, ManyPeekahead) {
 
 // Validates that creating a scheduler using the createWithPicks (with 0 picks)
 // is equal to creating an empty scheduler and adding entries one after the other.
-TEST_F(EdfSchedulerTest, EqualityAfterCreateEmpty) {
+TEST_F(EdfSchedulerTest, SchedulerWithZeroPicksEqualToEmptyWithAddedEntries) {
   constexpr uint32_t num_entries = 128;
   std::vector<std::shared_ptr<uint32_t>> entries;
   entries.reserve(num_entries);
@@ -193,7 +193,7 @@ TEST_F(EdfSchedulerTest, EqualityAfterCreateEmpty) {
 // Validates that creating a scheduler using the createWithPicks (with 5 picks)
 // is equal to creating an empty scheduler and adding entries one after the other,
 // and then performing some number of picks.
-TEST_F(EdfSchedulerTest, EqualityAfterCreateWithPicks) {
+TEST_F(EdfSchedulerTest, SchedulerWithSomePicksEqualToEmptyWithAddedEntries) {
   constexpr uint32_t num_entries = 128;
   // Use double-precision weights from the range [0.01, 100.5].
   // Using different weights to avoid a case where entries with the same weight
@@ -272,7 +272,7 @@ void firstPickTest(const std::vector<double> weights) {
 // Validates that after creating schedulers using the createWithPicks (with random picks)
 // and then performing a "first-pick", the distribution of the "first-picks" is
 // equal to the weights.
-TEST_F(EdfSchedulerTest, CreateWithPicksFirstPickDistribution) {
+TEST_F(EdfSchedulerTest, SchedulerWithRandomPicksFirstPickDistribution) {
   firstPickTest({25.0, 75.0});
   firstPickTest({1.0, 99.0});
   firstPickTest({50.0, 50.0});