Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

sapling->taddr after NU5 activation causes bad-txns-sapling-spend-description-invalid error #89

Closed
softminus opened this issue May 31, 2022 · 3 comments

Comments

@softminus
Copy link

sasha_work@seasonal-dream zecwallet-light-cli % git rev-parse HEAD; git status; cargo build > /dev/null; cargo run
657024be8473fb5f821f3a01d96e30341f0f6a0a
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
    Finished dev [unoptimized + debuginfo] target(s) in 0.12s
    Finished dev [unoptimized + debuginfo] target(s) in 0.11s
     Running `target/debug/zecwallet-cli`
Lightclient connecting to https://lwdv3.zecwallet.co:443/
{
  "result": "success"
}
Ready!
(main) Block:1687131 (type 'help') >> send t1etJZT2pHLem9B4GCk3o3QRFE3di5ywhKX 100000
0: Creating transaction sending 100000 ztoshis to 1 addresses
0: Selecting notes
0: Adding 1 notes and 0 utxos
0: Adding output
0: Building transaction
Progress: 1
Progress: 2
Progress: 3
25: Transaction created
Transaction ID: 2053858e855485b5e3da80501bebb65459100d58b047576c7aa48ca162a83618
{
  "error": "Error: SendResponse { error_code: -26, error_message: \"16: bad-txns-sapling-spend-description-invalid\" }"
}
(main) Block:1687131 (type 'help') >> 
@softminus
Copy link
Author

breaks similarly for sapling->sapling:

(main) Block:1687136 (type 'help') >> new z
[
  "zs1wrhaeq5df89sy6rm48kuwq8njadqes4fa8wfyjdqagmf6k8v3f7e4uvgze4zx9gy9y60xaxqf3p"
]
(main) Block:1687136 (type 'help') >> send zs1wrhaeq5df89sy6rm48kuwq8njadqes4fa8wfyjdqagmf6k8v3f7e4uvgze4zx9gy9y60xaxqf3p 100000
0: Creating transaction sending 100000 ztoshis to 1 addresses
0: Selecting notes
0: Adding 1 notes and 0 utxos
0: Adding output
0: Building transaction
Progress: 1
Progress: 2
Progress: 3
23: Transaction created
Transaction ID: cccaada3ab3a7124f02d595848345cb4243128d231ee4b0d7bc711a9fe7b9acc
{
  "error": "Error: SendResponse { error_code: -26, error_message: \"16: bad-txns-sapling-spend-description-invalid\" }"
}
(main) Block:1687136 (type 'help') >> 

@adityapk00
Copy link
Owner

Looking into it....

@str4d
Copy link
Contributor

str4d commented May 31, 2022

This error corresponds to a verification failure in https://github.com/zcash/librustzcash/blob/73d9395c9d3c5fa81fc7becd363a2c1a51772a76/zcash_proofs/src/sapling/verifier.rs#L31-L99 (or, less likely, the FFI glue that calls it). My initial guess is the wrong consensus branch ID is being used, causing the Sapling signature to be invalid. But it could also be e.g. an invalid proof.

ghost pushed a commit to Zondax/zecwallet-light-cli that referenced this issue Jul 27, 2022
ghost pushed a commit to Zondax/zecwallet-light-cli that referenced this issue Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants