Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ShowFullTextInRSS creates invalid RSS feed #1385

Closed
schroedingersZombie opened this issue Jan 6, 2024 · 3 comments · Fixed by #1411
Closed

[BUG] ShowFullTextInRSS creates invalid RSS feed #1385

schroedingersZombie opened this issue Jan 6, 2024 · 3 comments · Fixed by #1411
Labels
bug Something isn't working

Comments

@schroedingersZombie
Copy link

schroedingersZombie commented Jan 6, 2024 •
edited
Loading

Describe the bug
Commit #00488d0 introduces an error, when site.params.showFullTextInRSS is st to true.

It removes the xmlns:content="http://purl.org/rss/1.0/modules/content/" attribute in the rss tag. This is required for the content:encoded tag containing the full text.

  • Hugo Version [ >=0.112.4 expected]: 121.2
  • Theme Version [e.g. v4.0, master, or commit-id ]: master

Steps to reproduce the behavior:
insert

params:
  showFullTextInRss: true

into hugo.yaml.
Paste https://yoursite.net/index.xml into https://validator.w3.org/feed/check.cgi
image

Expected behavior:
RSS feed validates successfully.

Edit: just noticed, I forgot to type a title
@schroedingersZombie schroedingersZombie added the bug Something isn't working label Jan 6, 2024
@schroedingersZombie schroedingersZombie changed the title [BUG] [BUG] ShowFullTextInRSS creates invalid RSS feed Jan 7, 2024
@Yuk-0v0
Copy link

Yuk-0v0 commented Jan 25, 2024

same problem

@vindex10
Copy link

Hi! This PR fixes the problem, although it also brings a feature 🙃

#1370

@schroedingersZombie
Copy link
Author

Thank you very much! :)

@adityatelange adityatelange linked a pull request Feb 3, 2024 that will close this issue
Adding xmlns:content namespace to RSS feed and only write content:encoded if something on .Content #1411
Merged
7 tasks
adityatelange pushed a commit that referenced this issue Feb 3, 2024
@DJLink
Adding xmlns:content namespace to RSS feed and only write content:enc…
a4a0f8d 
…oded if something on .Content (#1411)

* Added xmlns:content namespace for valid RSS feeds with content:encoded

* Only write <content:encoded> in RSS if ShotFullTextinRSS and .Content has something

fixes: #1385
ayedaemon pushed a commit to ayedaemon/hugo-PaperMod that referenced this issue Mar 27, 2024
@DJLink @ayedaemon
Adding xmlns:content namespace to RSS feed and only write content:enc…
0d4a2f3 
…oded if something on .Content (adityatelange#1411)

* Added xmlns:content namespace for valid RSS feeds with content:encoded

* Only write <content:encoded> in RSS if ShotFullTextinRSS and .Content has something

fixes: adityatelange#1385
jdxgfty pushed a commit to jdxgfty/hugo-PaperMod that referenced this issue Nov 3, 2024
@DJLink
Adding xmlns:content namespace to RSS feed and only write content:enc…
55599d9 
…oded if something on .Content (adityatelange#1411)

* Added xmlns:content namespace for valid RSS feeds with content:encoded

* Only write <content:encoded> in RSS if ShotFullTextinRSS and .Content has something

fixes: adityatelange#1385
nsrahmad pushed a commit to nsrahmad/hugo-PaperMod that referenced this issue Dec 7, 2024
@DJLink @nsrahmad
Adding xmlns:content namespace to RSS feed and only write content:enc…
48cb8d2 
…oded if something on .Content (adityatelange#1411)

* Added xmlns:content namespace for valid RSS feeds with content:encoded

* Only write <content:encoded> in RSS if ShotFullTextinRSS and .Content has something

fixes: adityatelange#1385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding xmlns:content namespace to RSS feed and only write content:encoded if something on .Content
3 participants
@vindex10 @schroedingersZombie @Yuk-0v0