Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset.css needs to be placed first within css list, it is currently not being forced to be first #280

Closed
subsoap opened this issue Mar 1, 2021 · 5 comments · Fixed by #317

Comments

@subsoap
Copy link
Contributor

subsoap commented Mar 1, 2021

reset.css should not be able to override main.css, which is possible now.

@adityatelange
Copy link
Owner

adityatelange commented Mar 1, 2021

Doesn't matter if it works fine

@subsoap
Copy link
Contributor Author

subsoap commented Mar 1, 2021

Fixing it may be annoying to do since putting the order right would probably break other things, but the way it is now it will just make it a little bit troublesome to maintain the CSS from outsiders to the project.

@adityatelange
Copy link
Owner

What solution do you suggest here ?

@subsoap
Copy link
Contributor Author

subsoap commented Mar 18, 2021

Force reset.css to be the first CSS and then go through any issues that come up until they are resolved. This can be checked by comparing CSS rules. Maybe asking in the Hugo forum for ideas / CSS communities on a good way to fix it would give a better idea.

Put reset.css into is own reset folder so it's not included in common or extended and then in head.html reference it first just after <!-- Styles --> then they can be concacted as reset + common + extended.

I've not tested that myself to see what would happen but it should work to fix the order. Then all discrepancies between reset and common would need to be fixed since right now there are rules in reset which override the other css in common.

Like you say it works right now doing this is only necessary to make it easier and clearer to maintain in the future.

@adityatelange
Copy link
Owner

Force reset.css to be the first CSS and then go through any issues that come up until they are resolved. This can be checked by comparing CSS rules. Maybe asking in the Hugo forum for ideas / CSS communities on a good way to fix it would give a better idea.

Put reset.css into is own reset folder so it's not included in common or extended and then in head.html reference it first just after <!-- Styles --> then they can be concacted as reset + common + extended.

I've not tested that myself to see what would happen but it should work to fix the order. Then all discrepancies between reset and common would need to be fixed since right now there are rules in reset which override the other css in common.

Like you say it works right now doing this is only necessary to make it easier and clearer to maintain in the future.

Changing names of underlying files is what I don't want as there are people overriding reset.css and that will break their website if they don't out attention to what they are merging. But there is no other simpler option whatsoever rn

@adityatelange adityatelange linked a pull request Mar 22, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants