Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split-up css into sub-parts #317

Merged
merged 2 commits into from
Mar 27, 2021
Merged

Split-up css into sub-parts #317

merged 2 commits into from
Mar 27, 2021

Conversation

adityatelange
Copy link
Owner

@adityatelange adityatelange commented Mar 22, 2021 •
edited 

. (assets/css)
├── common
│   ├── 404.css
│   ├── archive.css
│   ├── footer.css
│   ├── header.css
│   ├── main.css
│   ├── post-entry.css
│   ├── post-single.css
│   ├── profile-mode.css
│   ├── search.css
│   └── terms.css
├── core
│   ├── reset.css
│   ├── theme-vars.css
│   └── zmedia.css
├── extended
│   └── blank.css
├── hljs
│   └── an-old-hope.min.css
└── opt

@adityatelange adityatelange linked an issue Mar 22, 2021 that may be closed by this pull request
reset.css needs to be placed first within css list, it is currently not being forced to be first #280
Closed
@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adityatelange adityatelange marked this pull request as ready for review March 25, 2021 10:40
@adityatelange
Copy link
Owner Author

@kdkasad Can you please verify if everything is working fine with this change?

@kdkasad
Copy link
Contributor

kdkasad commented Mar 25, 2021

@kdkasad Can you please verify if everything is working fine with this change?

Everything looks good to me!

@adityatelange
Copy link
Owner Author

@kdkasad Can you please verify if everything is working fine with this change?

Everything looks good to me!

Thanks for confirming 👍

@adityatelange adityatelange merged commit e503367 into master Mar 27, 2021
@adityatelange adityatelange deleted the css_separate branch March 27, 2021 07:33
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
@adityatelange
[BREAKING] Split-up css into sub-parts (adityatelange#317)
b0cb53c 
* Move styles into 3 different locations
- core
- common
- hljs

* Load all stylesheets in proper order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reset.css needs to be placed first within css list, it is currently not being forced to be first
2 participants
@adityatelange @kdkasad