Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

socialIcons, fix: apply safeURL to make all URI schemes work #1266

Merged
merged 1 commit into from
Jul 23, 2023
Merged

socialIcons, fix: apply safeURL to make all URI schemes work #1266

merged 1 commit into from
Jul 23, 2023

Conversation

deining
Copy link
Contributor

@deining deining commented Jul 16, 2023

What does this PR change? What problem does it solve?

Currently, a socialIcon defined as below does not work:

socialIcons:
  - name: xmpp
    url: xmpp:address@instance.com

This PR fixes this.

Was the change discussed in an issue or in the Discussions before?

Yes, this issue was discussed in this thread on hugo discourse board.

PR Checklist

  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adityatelange adityatelange merged commit 61bf918 into adityatelange:master Jul 23, 2023
@deining deining deleted the fix-safeURL branch July 23, 2023 09:56
zer0ttl pushed a commit to zer0ttl/hugo-PaperMod that referenced this pull request Jan 24, 2024
@deining
socialIcons, fix: apply safeURL to make all URI schemes work (adityat…
296ce2b 
…elange#1266)
jdxgfty pushed a commit to jdxgfty/hugo-PaperMod that referenced this pull request Nov 3, 2024
@deining
socialIcons, fix: apply safeURL to make all URI schemes work (adityat…
e451f82 
…elange#1266)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityatelange adityatelange adityatelange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deining @adityatelange