Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add social icon of juejin #1347

Merged
merged 3 commits into from
Jan 7, 2024
Merged

add social icon of juejin #1347

merged 3 commits into from
Jan 7, 2024

Conversation

barnett617
Copy link
Contributor

@barnett617 barnett617 commented Dec 1, 2023 •
edited
Loading

from https://simpleicons.org/
for users of https://juejin.cn/
reference to #1286

What does this PR change? What problem does it solve?

Was the change discussed in an issue or in the Discussions before?

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@adityatelange adityatelange added the icons Related to Icons label Dec 10, 2023
adityatelange
adityatelange requested changes Dec 23, 2023
View reviewed changes
Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icons are listed in svg sorted alphabetically by their name. kindly update

barnett617
barnett617 commented Dec 28, 2023
View reviewed changes
Copy link
Contributor Author

@barnett617 barnett617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

adityatelange
adityatelange approved these changes Jan 7, 2024
View reviewed changes
Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adityatelange adityatelange merged commit 6a5a677 into adityatelange:master Jan 7, 2024
1 check passed
zer0ttl pushed a commit to zer0ttl/hugo-PaperMod that referenced this pull request Jan 24, 2024
@barnett617
add social icon of juejin (adityatelange#1347)
06db13f
nsrahmad pushed a commit to nsrahmad/hugo-PaperMod that referenced this pull request Jan 27, 2024
@barnett617 @nsrahmad
add social icon of juejin (adityatelange#1347)
9395463
ayedaemon pushed a commit to ayedaemon/hugo-PaperMod that referenced this pull request Mar 27, 2024
@barnett617 @ayedaemon
add social icon of juejin (adityatelange#1347)
066ff86
jdxgfty pushed a commit to jdxgfty/hugo-PaperMod that referenced this pull request Nov 3, 2024
@barnett617
add social icon of juejin (adityatelange#1347)
9798504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityatelange adityatelange adityatelange approved these changes

Assignees
No one assigned
Labels
icons Related to Icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barnett617 @adityatelange