Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social icon for Signal #1446

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

proprietary
Copy link
Contributor

@proprietary proprietary commented Mar 2, 2024

Signal added support for usernames and links. So it seems likely people will want to add an icon to their sites.

The icon in the SVG is a derivative of this:

https://commons.wikimedia.org/wiki/File:Signal-Logo.svg

which is in the public domain and/or has a permissive license.

This is what it looks like:

Screenshot 2024-03-02 at 9 14 03 AM

What does this PR change? What problem does it solve?

It just adds a SVG icon for Signal.

Was the change discussed in an issue or in the Discussions before?

No

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

Signal added support for usernames and links
Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adityatelange adityatelange merged commit 9e7a589 into adityatelange:master Mar 7, 2024
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ayedaemon pushed a commit to ayedaemon/hugo-PaperMod that referenced this pull request Mar 27, 2024
jdxgfty pushed a commit to jdxgfty/hugo-PaperMod that referenced this pull request Nov 3, 2024
nsrahmad pushed a commit to nsrahmad/hugo-PaperMod that referenced this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants