Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copyright field rendering in RSS feed #1479

Merged

Conversation

KonishchevDmitry
Copy link
Contributor

What does this PR change? What problem does it solve?

The copyright is rendered in footer as {{ site.Copyright | markdownify }} which assumes it to be Markdown text, but RSS feed template doesn't ready for Markdown now.

Was the change discussed in an issue or in the Discussions before?

No.

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

The copyright is rendered in footer as `{{ site.Copyright | markdownify }}`
which assumes it to be Markdown text, but RSS feed template doesn't ready
for Markdown now.
Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@adityatelange adityatelange merged commit beb281a into adityatelange:master Apr 13, 2024
1 check passed
@KonishchevDmitry KonishchevDmitry deleted the rss-copyright-fix branch April 13, 2024 07:46
hankmor pushed a commit to hankmor/hugo-PaperMod that referenced this pull request May 31, 2024
The copyright is rendered in footer as `{{ site.Copyright | markdownify }}`
which assumes it to be Markdown text, but RSS feed template doesn't ready
for Markdown now.
jdxgfty pushed a commit to jdxgfty/hugo-PaperMod that referenced this pull request Nov 3, 2024
The copyright is rendered in footer as `{{ site.Copyright | markdownify }}`
which assumes it to be Markdown text, but RSS feed template doesn't ready
for Markdown now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants