-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add social icon for snapchat #188
Add social icon for snapchat #188
Conversation
This PR will close #186 when merged. |
@adityatelange Please review and merge the PR at your convenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't match style of SVGs already present.
Won't look good with dark and light mode.
It does look good, Changing the SVG would break Snapchat's ToS which states: "Don’t alter, rotate, or modify the Ghost logo in any way, such as by changing colors or adding" Edit: There is a potential change regarding the view port size for SVG. I will have a look into that. |
@daksh7011 Why not use icon from simpleicons.org and modify accordingly ? Better licensing, smaller size. |
Kudos, SonarCloud Quality Gate passed!
|
@adityatelange I have changed the svg from official one to SimpleIcons.org. Have a look at your convenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Although it is not of wire type, it's fine IMO.
Merging, Thanks !
@daksh7011 It would be great if you could also add the icon to icon list :) |
@adityatelange I can add a alternate logo with just strokes as |
Add social icon for Snapchat.
The SVG is taken from Snapchat official assets, So please try not to modify it.