Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social icon for snapchat #188

Merged
merged 3 commits into from
Jan 23, 2021

Conversation

daksh7011
Copy link
Contributor

Add social icon for Snapchat.

The SVG is taken from Snapchat official assets, So please try not to modify it.

@daksh7011
Copy link
Contributor Author

This PR will close #186 when merged.

@daksh7011
Copy link
Contributor Author

@adityatelange Please review and merge the PR at your convenience.

Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't match style of SVGs already present.
Won't look good with dark and light mode.

@adityatelange adityatelange linked an issue Jan 23, 2021 that may be closed by this pull request
@daksh7011
Copy link
Contributor Author

daksh7011 commented Jan 23, 2021

Light Mode preview
image

Dark Mode preview:
image

It does look good, Changing the SVG would break Snapchat's ToS which states: "Don’t alter, rotate, or modify the Ghost logo in any way, such as by changing colors or adding"

Edit: There is a potential change regarding the view port size for SVG. I will have a look into that.

@adityatelange
Copy link
Owner

@daksh7011 Why not use icon from simpleicons.org and modify accordingly ? Better licensing, smaller size.

@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@daksh7011
Copy link
Contributor Author

@adityatelange I have changed the svg from official one to SimpleIcons.org.

Have a look at your convenience.

Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Although it is not of wire type, it's fine IMO.
Merging, Thanks !

@adityatelange adityatelange merged commit 24afe95 into adityatelange:master Jan 23, 2021
@adityatelange
Copy link
Owner

@daksh7011 It would be great if you could also add the icon to icon list :)
https://github.com/adityatelange/hugo-PaperMod/blob/exampleSite/content/posts/papermod/papermod-icons.md

@daksh7011
Copy link
Contributor Author

@adityatelange I can add a alternate logo with just strokes as snapchat-alt. Let me know, I will add it.

@adityatelange adityatelange added the icons Related to Icons label Jun 11, 2021
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons Related to Icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new icon for Snapchat
2 participants