-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch fingerprinting func in templates #195
patch fingerprinting func in templates #195
Conversation
fixes the "failed to find a valid digest..." error reference: https://gohugo.io/hugo-pipes/fingerprint/
fixes the "failed to find a valid digest..." error reference: https://gohugo.io/hugo-pipes/fingerprint/
Kudos, SonarCloud Quality Gate passed!
|
@hlwjia The current usage is valid. Also the default one used is So this won't fix "failed to find a valid digest..." error |
@adityatelange I noticed that when I deployed a site of mine with your theme, I get the same hash from my css filename as yours at https://adityatelange.github.io/hugo-PaperMod/. Starts with I thought maybe your Now, after reading your reply. Thanks for that. I didn't know the method alias before. I got confused why it didn't work for me. Then I tested with, again, Guess what! It doesn't work again. And then I tested with Surprisingly, it works! Now I'm really curious why only Well, it's probably not the issue with your theme. But I'm just documenting what I got here. Feel free to close this PR. |
Just did another test with Any clue why only the sha256 didn't work? Again, feel free to close if it's not really what you'd like to think about. Technically, it's not an issue with this repo. |
Maybe gohugoio/hugo#7882 ? I'm not really sure but it sometimes does not recalculate, is what my experience is ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should merge this since this also generates a smaller hash, which does the same job.
Do you want me to change it back to use method alias If you want, I can update it to I actually prefer cleaner alias :D |
9e99493#commitcomment-46358507 also this is an issue. I didn't read docs https://www.w3.org/TR/SRI/#cryptographic-hash-functions before merging. It says |
@adityatelange Thanks for the additional research. Sorry for causing any inconvenience. :( |
…dityatelange#195)" This reverts commit 823f14c.
Other params instead of
md5
aresha256
,sha512
,sha384
(from Hugo 0.55).