-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Overriding of ToC #329
Conversation
I like this idea.
I'd say add the proper indentation but keep it as a separate commit. That way it's still easy to see what's changed by just not looking at that commit (or by using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good except for that one style change. Testing all looks fine; nothing else seems to break.
assets/css/common/post-single.css
Outdated
@@ -210,7 +210,7 @@ | |||
display: block; | |||
margin: auto 0; | |||
padding: 10px; | |||
color: rgba(255, 255, 255, .8); | |||
color: var(--primary); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change breaks the text color of code blocks in light mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arg, I should not have used my master
branch for the PR 🙈 I reverted this change there 👍 (b46ada5)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It might make sense to rebase on top of upstream's master, so there aren't two extra commits, but that's up to you and/or @adityatelange.
Done in 8d3c7fd 👍 |
Awesome, thanks! I ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good now. No side effects appeared during testing.
I say it's ready to merge.
Fix color of "Name" class in Code Highlighting Revert "Fix color of "Name" class in Code Highlighting" This reverts commit a94d424. Fix indentation
Kudos, SonarCloud Quality Gate passed! |
Allows Overriding of ToC
Motivation: I'd like to use the title of a post as the title of the ToC as well (since I have it floating left of the text).
Problem: The "outer" part of the ToC (which includes the title) is currently defined in the
single.html
, and only the<ul>
is defined in thetoc.html
-partial.This PR moves the complete html-code of the ToC into the
toc.html
partial.single.html
, to be consistent with with other conditional partialscomments
andshare_icons
.toc.html
to keep the diff easier. If you prefer proper indentation, I'll gladly do that 👍