Fix path in editPost URL for Windows #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.File.Path` is OS dependant and uses `\` as directory separator. This leads to
cases where posts get the wrong URL, if in a sub folder, e.g.
`content/posts/folder\post.md`.
One idea was to replace `\` with `/` this however breaks valid files (on Unix
systems) which include `\` in the file name.
According to the docs [`path.Join`](layouts/partials/edit_post.html) is OS
unaware and converts to a Unix-like path.
> Note: All path elements on Windows are converted to slash ('/') separators.
PS: It looks like hugo also uses this internally to build URLs.
PPS: Solution was discussed in adityatelange#278.
|
Kudos, SonarCloud Quality Gate passed!
|
mbrukman
pushed a commit
to mbrukman/hugo-PaperMod
that referenced
this pull request
Apr 4, 2021
#5b5d67 -> adityatelange#333
kylethedeveloper
pushed a commit
to kylethedeveloper/hugo-PaperMod
that referenced
this pull request
Feb 21, 2023
#5b5d67 -> adityatelange#333
kylethedeveloper
pushed a commit
to kylethedeveloper/hugo-PaperMod
that referenced
this pull request
Feb 21, 2023
`.File.Path` is OS dependant and uses `\` as directory separator. This leads to
cases where posts get the wrong URL, if in a sub folder, e.g.
`content/posts/folder\post.md`.
One idea was to replace `\` with `/` this however breaks valid files (on Unix
systems) which include `\` in the file name.
According to the docs [`path.Join`](layouts/partials/edit_post.html) is OS
unaware and converts to a Unix-like path.
> Note: All path elements on Windows are converted to slash ('/') separators.
PS: It looks like hugo also uses this internally to build URLs.
PPS: Solution was discussed in adityatelange#278.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.File.Pathis OS dependant and uses\as directory separator. This leads tocases where posts get the wrong URL, if in a sub folder, e.g.
content/posts/folder\post.md.One idea was to replace
\with/this however breaks valid files (on Unixsystems) which include
\in the file name.According to the docs
path.Joinis OSunaware and converts to a Unix-like path.
PS: It looks like hugo also uses this internally to build URLs.
PPS: Solution was discussed in #278.