Fix profileMode imageUrl preloaded on every page #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead we now only preload on the home page. Closes #494 Signed-off-by: Daniel F. Dickinson <20735818+danielfdickinson@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
danielfdickinson
deleted the
pr-fix-profilemode-imageurl-preload-every-page
branch
kylethedeveloper
pushed a commit
to kylethedeveloper/hugo-PaperMod
that referenced
this pull request
Feb 21, 2023
Instead we now only preload on the home page. Closes adityatelange#494 Signed-off-by: Daniel F. Dickinson <20735818+danielfdickinson@users.noreply.github.com>
kylethedeveloper
pushed a commit
to kylethedeveloper/hugo-PaperMod
that referenced
this pull request
Feb 21, 2023
Instead we now only preload on the home page. Closes adityatelange#494 Signed-off-by: Daniel F. Dickinson <20735818+danielfdickinson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead we now only preload on the home page.
Closes #494
What does this PR change? What problem does it solve?
Solves #494 by only preloading imageUrl on homepage.
Was the change discussed in an issue or in the Discussions before?
Created issue and PR about same time. Will update PR if needed, but for such a simple issue/fix it is unlikely (in #149 @adityatelange indicated that profileMode is only for homepage).
PR Checklist