Add width and height attributes to cover images #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfdickinson
suggested changes
Aug 18, 2021
There was a problem hiding this comment.
Thank you for the changes. I'm not sure what I think of the formatting changes, mostly because I'm not sure what the maintainer prefers, but this looks good. Also, there is an issue #499 you might want to reference.
|
Thank you for the hint! I inserted the link in my initial comment. |
|
Kudos, SonarCloud Quality Gate passed!
|
adityatelange
approved these changes
Aug 22, 2021
3 tasks
kylethedeveloper
pushed a commit
to kylethedeveloper/hugo-PaperMod
that referenced
this pull request
Feb 21, 2023
- Ensures that the browser can allocate the correct amount of space in the document while the image is loading. - Reduces CLS adityatelange#499
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
When using cover images the layout shifts on initial load because the image dimensions can only be determined by the browser after loading the images.
I followed the recommendations from this website linked to from Lighthouse in Chrome and added the width and height attributes to the cover images. From this the browser can determine the aspect ratio before loading any images.
Additionally, in the CSS file I have added the
height: autodirective to the.entry-cover imgselector. The height is then calculated based on the actual available width.Was the change discussed in an issue or in the Discussions before?
Fix for #499 in the Discussions
PR Checklist