Never display the toc when it would be empty #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMO, there is no point inserting a table of content if the page has no titles because in this case, the table of contents is empty.
|
Kudos, SonarCloud Quality Gate passed!
|
adityatelange
approved these changes
Aug 27, 2021
kylethedeveloper
pushed a commit
to kylethedeveloper/hugo-PaperMod
that referenced
this pull request
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO, there is no point inserting a table of content if the page has no titles
because in this case, the table of contents is empty.
What does this PR change? What problem does it solve?
If TOC is enable on a page but the page has no titles, we end up with an empty TOC element, like so:
it make more sense in my opinion to avoid showing the table of content if it would be empty.
The alternative is that the user has to disable the TOC with the setting for each page that has no titles, a fairly manual and tedious process.
Was the change discussed in an issue or in the Discussions before?
No
PR Checklist
I have enabled maintainer edits for this PR.
This change does not include any CDN resources/links.
This change does not include any unrelated scripts such as bash and python scripts.