Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix div not allowed in summary element in ToC #552

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Fix div not allowed in summary element in ToC #552

merged 1 commit into from
Sep 3, 2021

Conversation

danielfdickinson
Copy link
Contributor

What does this PR change? What problem does it solve?

As per Mozilla Developer Network detail summary element page only 'phrasing elements' and/or one element of heading content are allowed inside a <summary> element.

Once again found by (valid) html validator complaint (I turn off the parts that are about opinions vs. HTML standards).

The table of contents <summary> currently contains a <div>.

I have replaced the <div> with a <span> and it appears to work on https://www.princesandmadmen.ca/post/schizophrenia-talk/ although increasing the font-size might be desirable.

Was the change discussed in an issue or in the Discussions before?

Closes #550

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

Signed-off-by: Daniel F. Dickinson <20735818+danielfdickinson@users.noreply.github.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adityatelange adityatelange merged commit 9a20b2e into adityatelange:master Sep 3, 2021
@danielfdickinson danielfdickinson deleted the pr-toc-div-not-allowed branch September 3, 2021 14:07
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ToC: <div> not allowed inside <summary> element
2 participants