-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rgba to rgb #560
Rgba to rgb #560
Conversation
@adityatelange Looks pretty solid to me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Just bumping this. I'd happily help deal with the conflicts, but I don't have write permission. 😅 |
This reverts commit 5cba065.
- Should fix search engines picking up elements inside noscript
Kudos, SonarCloud Quality Gate passed!
|
- Except for code-copy btn - Emojis were affected by theme opacity values, fixes: adityatelange#557
What does this PR change? What problem does it solve?
Because the theme's colors are set using opacity instead of actual color values, they interfere with elements other than text. For example, dark elements styled by entry-content use the --secondary color of rgba(255, 255, 255, 0.56). The text reads fine as a grey color against the black background, but if you add an emoji into your content it will also take on the 0.56 opacity value and look like it's fading away.
This PR includes: Same color, but no opacity issues.
The opacity of
go to top
button also changes hereWas the change discussed in an issue or in the Discussions before?
[BUG] Emojis affected by theme opacity values Fixes: #557
PR Checklist