Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output valid HTML #673

Merged
merged 4 commits into from
May 27, 2022
Merged

Output valid HTML #673

merged 4 commits into from
May 27, 2022

Conversation

kenohassler
Copy link
Contributor

@kenohassler kenohassler commented Dec 14, 2021 •
edited

What does this PR change? What problem does it solve?

The HTML created by hugo has two minor problems (report here):

  1. Error: Element ul not allowed as child of element span in this context.
  2. Error: No p element in scope but a p end tag seen.

This PR fixes both by replacing the <span> with a <div> in header.html and making sure that <p> tags are not nested in home_info.html.

Was the change discussed in an issue or in the Discussions before?
Error 1 was briefly discussed in #599, I found the other one.

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented May 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adityatelange adityatelange merged commit 6aced45 into adityatelange:master May 27, 2022
@kenohassler kenohassler deleted the html-fix branch May 28, 2022 10:36
romainx pushed a commit to romainx/hugo-PaperMod that referenced this pull request Jul 26, 2022
@kenohassler @romainx
Output valid HTML (adityatelange#673)
a76b818
minyeamer pushed a commit to minyeamer/hugo-PaperMod that referenced this pull request Sep 16, 2022
@kenohassler
Output valid HTML (adityatelange#673)
34c818e
dunklecat pushed a commit to dunklecat/hugo-PaperModX that referenced this pull request Oct 8, 2022
@kenohassler @dunklecat
Output valid HTML (adityatelange#673)
6cc1e76
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
@kenohassler
Output valid HTML (adityatelange#673)
a116653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityatelange adityatelange adityatelange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kenohassler @adityatelange