Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated post-single.css to set hr's border to 0 #870

Merged

Conversation

SebMtn
Copy link
Contributor

@SebMtn SebMtn commented Apr 4, 2022

What does this PR change? What problem does it solve?

The problem is that the hr element displays the wrong color at the extremities:

tip hr light

tip hr dark

This problem appears both in light and dark mode (though it is more visible in light mode). This issue breaks the consistency of the UI by introducing a jarring element at the extremities.
This PR modifies the css style of hr by setting a border size of 0 to solve this problem. It gives the hr element a unique color.
Here are the results with this patch:

tip hr light fixed

tip hr dark fixed

Was the change discussed in an issue or in the Discussions before?

This issue was not raised before.

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adityatelange adityatelange merged commit a55b951 into adityatelange:master Apr 19, 2022
romainx pushed a commit to romainx/hugo-PaperMod that referenced this pull request Jul 26, 2022
* Updated post-single.css to set hr's border to 0

* cleanup

Co-authored-by: Aditya Telange <21258296+adityatelange@users.noreply.github.com>
minyeamer pushed a commit to minyeamer/hugo-PaperMod that referenced this pull request Sep 16, 2022
* Updated post-single.css to set hr's border to 0

* cleanup

Co-authored-by: Aditya Telange <21258296+adityatelange@users.noreply.github.com>
dunklecat pushed a commit to dunklecat/hugo-PaperModX that referenced this pull request Oct 8, 2022
* Updated post-single.css to set hr's border to 0

* cleanup

Co-authored-by: Aditya Telange <21258296+adityatelange@users.noreply.github.com>
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
* Updated post-single.css to set hr's border to 0

* cleanup

Co-authored-by: Aditya Telange <21258296+adityatelange@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants