Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix malformed html structure of the translation list on post. #886

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Fix malformed html structure of the translation list on post. #886

merged 1 commit into from
Apr 19, 2022

Conversation

binick
Copy link
Contributor

@binick binick commented Apr 19, 2022

What does this PR change? What problem does it solve?

Fix malformed html structure of the translation list on post.

Was the change discussed in an issue or in the Discussions before?

Closes #879

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

adityatelange
adityatelange approved these changes Apr 19, 2022
View reviewed changes
Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@adityatelange adityatelange merged commit c0e7be6 into adityatelange:master Apr 19, 2022
@binick binick deleted the patch-1 branch April 19, 2022 15:04
romainx pushed a commit to romainx/hugo-PaperMod that referenced this pull request Jul 26, 2022
@binick @romainx
Fix malformed html structure of the translation list on post. (aditya…
7c88b2b 
…telange#886)

Moves "Translations" word out of `ul`
minyeamer pushed a commit to minyeamer/hugo-PaperMod that referenced this pull request Sep 16, 2022
@binick
Fix malformed html structure of the translation list on post. (aditya…
4bdacf8 
…telange#886)

Moves "Translations" word out of `ul`
dunklecat pushed a commit to dunklecat/hugo-PaperModX that referenced this pull request Oct 8, 2022
@binick @dunklecat
Fix malformed html structure of the translation list on post. (aditya…
2e9ee92 
…telange#886)

Moves "Translations" word out of `ul`
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
@binick
Fix malformed html structure of the translation list on post. (aditya…
3f16461 
…telange#886)

Moves "Translations" word out of `ul`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityatelange adityatelange adityatelange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Post translations list is not well-structured and broken WCAG 1.3.1
2 participants
@binick @adityatelange