Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Sourcehut SocialIcon #964

Merged
merged 2 commits into from
Jul 9, 2022
Merged

Conversation

biehlerj
Copy link
Contributor

@biehlerj biehlerj commented Jul 5, 2022

What does this PR change? What problem does it solve?

Icon in action in Profile Mode:

(Other icons included for display purposes)

  • Dark Mode
    image
  • Light Mode
    image

Was the change discussed in an issue or in the Discussions before?

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons are added alphabetical order of their names, please refactor accordingly.

@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@biehlerj
Copy link
Contributor Author

biehlerj commented Jul 8, 2022

Sorry about that. I should have looked more closely at the code to notice that it is in alphabetical order. I have submitted the changes. Please let me know if you need me to do anything else.

@adityatelange adityatelange merged commit 621c9f6 into adityatelange:master Jul 9, 2022
@adityatelange adityatelange linked an issue Jul 9, 2022 that may be closed by this pull request
romainx pushed a commit to romainx/hugo-PaperMod that referenced this pull request Jul 26, 2022
@adityatelange adityatelange added the icons Related to Icons label Aug 28, 2022
minyeamer pushed a commit to minyeamer/hugo-PaperMod that referenced this pull request Sep 16, 2022
dunklecat pushed a commit to dunklecat/hugo-PaperModX that referenced this pull request Oct 8, 2022
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons Related to Icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Social Icon for Sourcehut
2 participants