Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vimeo icon #975

Merged
merged 1 commit into from
Jul 24, 2022
Merged

add vimeo icon #975

merged 1 commit into from
Jul 24, 2022

Conversation

icy-comet
Copy link
Contributor

@icy-comet icy-comet commented Jul 11, 2022

What does this PR change? What problem does it solve?
Added Vimeo icon from simpleicons.org.

Here's a sample image of the icons if used on my site:
image

Was the change discussed in an issue or in the Discussions before?
Closes #840.

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@icy-comet icy-comet changed the title add xmpp icon add xmpp/micro.blog icon Jul 11, 2022
@icy-comet icy-comet changed the title add xmpp/micro.blog icon add xmpp & micro.blog icon Jul 11, 2022
@icy-comet icy-comet changed the title add xmpp & micro.blog icon add xmpp, micro.blog & vimeo icon Jul 15, 2022
@icy-comet icy-comet force-pushed the icon/xmpp branch 2 times, most recently from 7e057f4 to d4610c7 Compare July 18, 2022 09:38
@icy-comet icy-comet changed the title add xmpp, micro.blog & vimeo icon add vimeo icon Jul 18, 2022
@icy-comet
Copy link
Contributor Author

Since #733 was merged, I removed the commits adding XMPP and micro.blog icons.

Copy link
Owner

@adityatelange adityatelange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons are alphabetically ordered according to their name.
Can we place it in proper location?

@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adityatelange adityatelange merged commit 0f37c06 into adityatelange:master Jul 24, 2022
@icy-comet icy-comet deleted the icon/xmpp branch July 24, 2022 06:54
romainx pushed a commit to romainx/hugo-PaperMod that referenced this pull request Jul 26, 2022
@adityatelange adityatelange added the icons Related to Icons label Aug 28, 2022
minyeamer pushed a commit to minyeamer/hugo-PaperMod that referenced this pull request Sep 16, 2022
RoneoOrg added a commit to RoneoOrg/hugo-theme-offTheRecord that referenced this pull request Sep 30, 2022
* upstream/master: (51 commits)
  [PATCH] Fix date format in schema and opengraph templates
  Fix error with profileMode imageUrl on Windows devices when imageUrl was set with external link resources.Get throws an error
  Use Nullish Coalescing Operator with Fastsearch (adityatelange#1033)
  Update bug report template
  add sketchfab icon (adityatelange#998)
  Fix spotify icon svg (adityatelange#997)
  Updating pagination strings for de (adityatelange#1024)
  Add icons for AniList and osu! (adityatelange#1022)
  Fix spacing around `rawhtml` shortcode (adityatelange#1018)
  Add param 'hiddenInHomeList' to hide certain post from home page
  Fix Code Smell: Unexpected var, use let or const instead.
  Add social icons for DeviantArt and Patreon (adityatelange#1013)
  Adding threema as social icon (adityatelange#1012)
  Feat: Add page nums in list pages
  pages: use github actions as build source - remove older build config (Classic Pages)
  Add more ja translations (adityatelange#1004)
  Updating pagination strings for bn: (adityatelange#1002)
  Add optional custom "title" for social links (adityatelange#999)
  Add a meta tag for naver site verification (adityatelange#991)
  add vimeo icon (adityatelange#975)
  ...
dunklecat pushed a commit to dunklecat/hugo-PaperModX that referenced this pull request Oct 9, 2022
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons Related to Icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vimeo social icon
2 participants