Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerization and import cleanup, code formatting #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

haluk
Copy link

@haluk haluk commented Feb 26, 2021

I prepared Dockerfile that one can run the package in a container for reproducibility. I also removed some unused imports and statements.

Copy link
Contributor

@espoirMur espoirMur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @haluk , I think to make the review process smother for the reviewer what do you think about bringing back the double quotes in place of the single quotes as they was in the application?

@haluk
Copy link
Author

haluk commented Mar 8, 2021

black code formatter automatically replaces single quotes with double quotes. I'm not sure if it has a setting not do to that.

@ivanistheone
Copy link

ivanistheone commented Mar 8, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants