Fix #74 - make extra arguments optional #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two different patterns..
One where the object was passed in and a bunch of "args" were created based on specific fields (probably not very extensible), then sometimes (or not) a couple extraArgs were applied. In this case, I tried to make the initial "args" creation more consistent, and allow them to be overridden with "extraArgs" ... I also made it so that any argument can be overridden, rather than the one or two options that were in the code.
The other pattern was just to pass the extra args directly to the "client" command... those were easy.
To make it all better, now we no longer need the "trello.Defaults()" on every single command. YAY!?
~tommy