Improve/fix HTTP status code conformance with actor usage and session endings across various statement types #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fined statements.
…ctor type is invalid (LTS test 005-1-invalid-au).
Change actor tests for requirement 9.2.0.0-* to only apply to cmi5 defined statements.
* Separate intentional HTTP 401 response checks from places where 403-only checks are needed. * Change status code check/response for agent profile requests with no agent parameter from 403 to 400.
…or an HTTP forbidden (403) for statements sent.
gavbaa
changed the title
gavbaa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR more accurately reflects the cmi5 spec intention for several instances of where and by what portion of the spec actors should be verified, and what HTTP status code errors are reasonable to return.