feature: add timeout argument to set timeout on docker-machine calls #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonivdv
reviewed
Feb 16, 2018
docker-machine-nfs.sh
Outdated
| @@ -137,7 +138,7 @@ setPropDefaults() | |||
| prop_mount_options="noacl,async" | |||
| prop_force_configuration_nfs=false | |||
| prop_use_ip_range=false | |||
| prop_use_ip= | |||
| prop_timeout=60 | |||
There was a problem hiding this comment.
Wouldn't it be better to not set a default value (thus it would be the default value of docker-machine) ?
There was a problem hiding this comment.
Good point. I updated the PR to not set the timeout value
|
Thanks again. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the vpshere driver, docker-machine commands will sometimes exceed the default 10s timeout. This allows users to set that to a higher number. I chose 60s as a default timeout value.