Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] dev from plotly:dev #269

Merged
merged 3 commits into from
Oct 11, 2024
Merged

[pull] dev from plotly:dev #269

merged 3 commits into from
Oct 11, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Oct 11, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Copy link

sourcery-ai bot commented Oct 11, 2024

Reviewer's Guide by Sourcery

This pull request makes two main changes: it modifies the JSON serialization in the component generator to remove whitespace, and it updates the changelog to reflect this change. The primary goal appears to be reducing the package size by minimizing the metadata.json files.

Class diagram for the component generator changes

classDiagram
    class ComponentGenerator {
        -metadata: JSON
        +generate_components()
    }
    note for ComponentGenerator "Updated JSON serialization to remove whitespace"
Loading

File-Level Changes

Change Details Files
Modified JSON serialization to remove whitespace
  • Changed json.dump() parameters to use compact separators
  • Removed indentation from JSON output
dash/development/component_generator.py
Updated CHANGELOG.md to reflect the metadata.json change CHANGELOG.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, pull[bot]!). We assume it knows what it's doing!

@pull pull bot added the ⤵️ pull label Oct 11, 2024
@pull pull bot merged commit a354a73 into admariner:dev Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant