add support for reinvocationPolicy #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kirill Makhonin <kirill.makhonin@bluerivertech.com>
|
@adrienjt could you please review this Pull Request? |
adrienjt
requested changes
Sep 7, 2023
There was a problem hiding this comment.
Hi @kirillmakhonin-brt , could you please document the new value in https://github.com/admiraltyio/admiralty/blob/master/charts/multicluster-scheduler/README.md#parameters ?
|
@adrienjt done, please check |
adrienjt
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Requests adds possibility to customize reinvocationPolicy for webhook deployed by HELM chart.
This closes #192 and allows to use admirality in conjunction with other webhooks
In order to provide backward compatibility - default value is set to
Never(as it is default for kubernetes)Docs: https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#reinvocation-policy