-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: template scheduler configs #209
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, templated values are sort of an anti-pattern actually, and making all of the KubeSchedulerConfiguration a value removes a lot of the abstraction provided by the chart. In practice, what are you trying to change specifically? Could the plugins
section be the value?
@adrienjt the one thing I'm trying to change is appending a pluginConfig to adjust the I think we can probably do better, just by templating the |
6932573
to
af3a333
Compare
af3a333
to
c489b41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would you test this? Can you for example set scoringStrategy in
admiralty/test/e2e/admiralty.sh
Lines 35 to 44 in b704bb7
h $i upgrade --install admiralty charts/multicluster-scheduler -n admiralty --create-namespace -f $VALUES \ | |
--set controllerManager.image.repository=admiralty-agent \ | |
--set scheduler.image.repository=admiralty-scheduler \ | |
--set postDeleteJob.image.repository=admiralty-remove-finalizers \ | |
--set restarter.image.repository=admiralty-restarter \ | |
--set controllerManager.image.tag=$VERSION-amd64 \ | |
--set scheduler.image.tag=$VERSION-amd64 \ | |
--set postDeleteJob.image.tag=$VERSION-amd64 \ | |
--set restarter.image.tag=$VERSION-amd64 | |
k $i delete pod --all -n admiralty |
850af94
to
6aa1a3b
Compare
6aa1a3b
to
67b2632
Compare
This change templates the proxy and candidate scheduler configs in values. It's useful for cases when a non-default plugin config is required.