Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Add more checks to longest increasing subarray test #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stefantds
Copy link

This PR proposes more tests for the "longest increasing subarray". Currently only the length of the subarray is checked. The suggested changes add more checks:

  • checks if the result object is valid
  • checks if the subarray is increasing

Context: while working on https://github.com/stefantds/go-epi-judge I got to look at some Java test code a bit closer. I've found some small potential improvements. I am opening a separate PR for each. Please have a look if there is something that can be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant