Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update buildcff2vf.py to catch changed exceptions #1088

Closed
josh-hadley opened this issue Feb 13, 2020 · 3 comments · Fixed by #1097
Closed

Update buildcff2vf.py to catch changed exceptions #1088

josh-hadley opened this issue Feb 13, 2020 · 3 comments · Fixed by #1097
Assignees
@josh-hadley
Labels
py-tools

Comments

@josh-hadley
Copy link
Collaborator

fonttools/fonttools#1821 changed exception handling in fonttools that could break buildcff2vf.py's handling scheme. Investigate and update buildcff2vf.py as needed.
@josh-hadley josh-hadley mentioned this issue Feb 13, 2020
Merged
@anthrotype
Copy link
Member

nikolaus added an alias to the old exception name in varLib.cff so there should not be any breakage

@josh-hadley
Copy link
Collaborator Author

I agree, but I'm going to check confirm anyway.

@josh-hadley
Copy link
Collaborator Author

josh-hadley commented Feb 14, 2020 •
edited
Loading

All buildcff2vf tests pass with fonttools/fonttools@4be6aaf. I will keep this open as a reminder to clean up and remove buildcff2vf.py's redefinition of MergeTypeError after fonttools is released with the changes from that PR.

@josh-hadley josh-hadley self-assigned this Feb 14, 2020
@josh-hadley josh-hadley mentioned this issue Feb 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josh-hadley josh-hadley

Labels
py-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[buildcff2fv] update to new fontTools exceptions adobe-type-tools/afdko
2 participants
@anthrotype @josh-hadley