Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[buildcff2fv] update to new fontTools exceptions #1097

Merged
merged 1 commit into from
Feb 26, 2020
Merged

[buildcff2fv] update to new fontTools exceptions #1097

merged 1 commit into from
Feb 26, 2020

Conversation

josh-hadley
Copy link
Collaborator

  • updated to catch (and generate) fontTools.varLib.cff.VarLibCFFPointTypeMergeError instead of old MergeTypeError
  • removed redefinition of MergeTypeError

closes #1088

@josh-hadley
[buildcff2fv] update to new fontTools exceptions
f761d32 
- updated to catch (and generate) `fontTools.varLib.cff.VarLibCFFPointTypeMergeError` instead of old `MergeTypeError`
- removed redefinition of `MergeTypeError`
cjchapman
cjchapman approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@cjchapman cjchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@josh-hadley josh-hadley merged commit 0903943 into develop Feb 26, 2020
@josh-hadley josh-hadley deleted the jh-update-buildcff2vf branch February 26, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjchapman cjchapman cjchapman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update buildcff2vf.py to catch changed exceptions
2 participants
@josh-hadley @cjchapman