test cases failing with long path

[cjchapman]

• spot_test.py - [spot] increase workstr buffer size and use snprintf to prevent overflow #1136
• buildmasterotfs_test.py
• convertfonttocid_test.py
• sfntdiff_test.py
• sfntedit_test.py

#1136 fixes some spot_test.py test cases that were failing with a very long path, but there are other tests that still fail with a long path.

I copied the tests folder to here:

/Users/cchapman/GitHub/adobe-type-tools/afdko/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/tests

...and these test cases failed:

buildmasterotfs_test.py::test_build_otfs 
convertfonttocid_test.py::test_mergeFontToCFF_bug570[1_fdict.ps-True] 
convertfonttocid_test.py::test_mergeFontToCFF_bug570[1_fdict.ps-False] 
convertfonttocid_test.py::test_mergeFontToCFF_bug570[3_fdict.ps-True] 
convertfonttocid_test.py::test_mergeFontToCFF_bug570[3_fdict.ps-False] 
sfntdiff_test.py::test_diff[args0-dflt.txt] 
sfntdiff_test.py::test_diff[args1-dflt.txt] 
sfntdiff_test.py::test_diff[args2-dflt.txt] 
sfntdiff_test.py::test_diff[args3-level1.txt] 
sfntdiff_test.py::test_diff[args4-level2.txt] 
sfntdiff_test.py::test_diff[args5-level3.txt] 
sfntdiff_test.py::test_diff[args6-level4.txt] 
sfntdiff_test.py::test_diff_otf_vs_ttf_bug626 
sfntdiff_test.py::test_not_font_files 
sfntdiff_test.py::test_date_and_time2 
sfntedit_test.py::test_no_options 
sfntedit_test.py::test_extract_table 
sfntedit_test.py::test_add_table 
sfntedit_test.py::test_linux_ci_failure_bug570 
sfntedit_test.py::test_missing_table_delete_bug160 
sfntedit_test.py::test_missing_table_extract_bug160 

[josh-hadley]

Noting for future reference as work is done on this that the buildmasterotfs test failure appears to arise from a subprocess call to sfntedit:

Command '['sfntedit', '-a', 'CFF =/var/folders/36/_6l2ld7165d5rdrlshlnc6v80000gn/T/tmp66y7332e', '[my home dir]/afdko/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/tests/buildmasterotfs_data/input/master0.otf']' died with <Signals.SIGABRT: 6>.

So it probably makes sense to focus on the sfntedit issue(s) first (and the fix for buildmasterotfs might come for free).