Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sfntedit, sfntdiff] fix long path failures #1159

Merged
merged 2 commits into from
Jun 10, 2020
Merged

[sfntedit, sfntdiff] fix long path failures #1159

merged 2 commits into from
Jun 10, 2020

Conversation

josh-hadley
Copy link
Collaborator

  • use larger buffer for file in sysOpenSearchpath in *sys.c
  • move declaration of file out of loop
  • use snprintf instead of sprintf

Closes #1139

@josh-hadley
[sfntedit] rework sysOpenSearchpath
2890c83 
Fix failure with very long file/pathnames.
@josh-hadley
[sfntdiff] rework sysOpenSearchpath
7c79d48 
Fix failures with very long path/filenames
cjchapman
cjchapman approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@cjchapman cjchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@josh-hadley josh-hadley merged commit 9503f95 into develop Jun 10, 2020
@josh-hadley josh-hadley deleted the jh-fix-long-path-failures branch June 10, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjchapman cjchapman cjchapman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test cases failing with long path
2 participants
@josh-hadley @cjchapman