Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makeinstancesufo] no longer allows extrapolation #1152

Closed
frankrolf opened this issue Jun 4, 2020 · 3 comments · Fixed by #1155
Closed

[makeinstancesufo] no longer allows extrapolation #1152

frankrolf opened this issue Jun 4, 2020 · 3 comments · Fixed by #1155

Comments

@frankrolf
Copy link
Member

frankrolf commented Jun 4, 2020

When explaining the principles of interpolation to students today, I noticed that the tool no longer allows instance values that go beyond the defined axis extremes (e.g. -200 in a 0 - 1000 axis).

The result in the above case is just an instance of interpolation value 0 (no complaints from makeinstancesufo)

I know extrapolation is not a typical use case, but it is allowed by mutator and great for demonstration and exploration. Could this change have happened with the addition of varLib in 7f09153 ?

@josh-hadley
Copy link
Collaborator

josh-hadley commented Jun 4, 2020

Ohh...yes, quite possibly. I think @punchcutter should check/confirm but I think this:
7f09153#diff-f2284e0a884b16cdbcc94dd2fea1d2caR416

...should probably be store_true instead of store_false. @frankrolf try running your command with --use-varlib, which sounds counter-intuitive, but with the current implementation, it means don't use varLib (set useVarLib to False) which should use MM and re-enable extrapolation. If that works, then definitely the above line is the issue and should be changed to store_true.

@punchcutter
Copy link
Contributor

Oh, that's not right. Guess I'd better check those tests again, too.

@frankrolf
Copy link
Member Author

Confirming that the --use-varlib option yields the result expected from Mutator.
True ¯_(ツ)_/¯ False

@frankrolf frankrolf changed the title makeinstancesufo no longer allows extrapolation [makeinstancesufo] no longer allows extrapolation Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants