Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[makeinstancesufo] fix use-varlib flag, check for extrapolation #1155

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

josh-hadley
Copy link
Collaborator

  • fix setting of the --use-varlib flag from command line arguments
  • add check for extrapolation and warn if an instance attempts to extrapolate when using varLib
  • update related tests

closes #1152

- use `store_true` action for `--use-varlib` flag
- add test case using extrapolation; test that extrapolation works when MutatorMath is in use (and fails when varlib is used)
- update validateDesignspaceDoc with an additional check for extrapolation (instance location dimension out-of-range for axis) when varlib is used
- update extrapolation test case to look for detailed warning generated by above
Copy link
Contributor

@punchcutter punchcutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josh-hadley josh-hadley merged commit cf5330a into develop Jun 8, 2020
@josh-hadley josh-hadley deleted the jh-fix-varlib-flag branch June 8, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[makeinstancesufo] no longer allows extrapolation
2 participants