Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ttfcomponentizer] Add warning when UFO public.postscriptNames key is present but empty #1198

Closed
josh-hadley opened this issue Jul 28, 2020 · 0 comments · Fixed by #1199
Closed
Assignees

Comments

@josh-hadley
Copy link
Collaborator

The presence/absence of the public.postscriptNames key in the UFO lib.plist used during the componentization process can have a major impact on how components are made, as it determines which glyph names will be used to select components. An empty dict for this key is assumed to indicate no difference between UFO and TTF glyph names, but currently no indication is given that this assumption is being acted upon. A warning for the case of an empty public.postscriptNames lib key could be useful for cases where an empty dict is unintentionally included in lib.plist. Addition of this warning should not change the overall behavior of ttfcomponentizer beyond printing a warning in the output.

Suggested wording for the warning:

WARNING: The contents of public.postscriptNames is empty. This may result in uncomponentized glyphs if final glyph names vary from production names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant