Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ttfcomponentizer] add warning for empty psnames #1199

Merged
merged 1 commit into from
Jul 28, 2020
Merged

[ttfcomponentizer] add warning for empty psnames #1199

merged 1 commit into from
Jul 28, 2020

Conversation

josh-hadley
Copy link
Collaborator

Description

Update ttfcomponentizer and related tests:

  • add a warning when UFO lib.plist public.postscriptNames key is present but empty
  • add test to ensure warning is issued for this condition

Closes #1198

@josh-hadley
[ttfcomponentizer] add warning for empty psnames
ef5c45e 
- add a warning when UFO lib.plist public.postscriptNames key is present but empty
- add test to ensure warning is issued for this condition
miguelsousa
miguelsousa approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@miguelsousa miguelsousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@josh-hadley josh-hadley merged commit d0e1771 into develop Jul 28, 2020
@josh-hadley josh-hadley deleted the jh-ttfcomponentizer-warning branch July 28, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelsousa miguelsousa miguelsousa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ttfcomponentizer] Add warning when UFO public.postscriptNames key is present but empty
2 participants
@josh-hadley @miguelsousa