Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[checkoutlinesufo] restore_contour_order fails in some situations #1291

Closed
punchcutter opened this issue Feb 2, 2021 · 2 comments · Fixed by #1296
Closed

[checkoutlinesufo] restore_contour_order fails in some situations #1291

punchcutter opened this issue Feb 2, 2021 · 2 comments · Fixed by #1296
Assignees

Comments

@punchcutter
Copy link
Contributor

In some outlines like the glyph in tests/checkoutlinesufo_data/input/contour-restore.ufo checkoutlinesufo fails to restore contour order because of the way the contours overlap by a single point.

Run
checkoutlinesufo -e --all contour-restore.ufo

and the result is

AssertionError: Failed assertion: duplicated start point on contour 3 at 616, 597 of glyph cid51107.

This stops the entire process, but we should never fail here. The main purpose of restore_contour_order is to attempt to keep compatibility the same across masters, but that's not always going to be possible, especially when removing overlaps. If we can't restore contour order then we should just report it.

@frankrolf
Copy link
Member

Related to #790, perhaps?

@punchcutter
Copy link
Contributor Author

Maybe related, but all of the files attached to #790 seem to work fine with the current checkoutlinesufo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants