[checkoutlinesufo] Fix restore_contour_order fail #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-hadley
requested changes
Feb 4, 2021
There was a problem hiding this comment.
Can you add a test case that checks for the Warning message when checkoutlinesufo is run on contour-restore.ufo? The current test case that uses that file doesn't hit this code (no warning is emitted) because it uses the ignore-contour-order flag.
You can probably just copy that case (test_ignore_contour_order) but remove the =ignore-contour-order from the options to runner(). Basically just reproduce the command @punchcutter mentions in #1291 and verify that the new Warning message is emitted ("Warning: duplicated start point on contour 3 at 616, 597 of glyph cid51107.").
josh-hadley
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1291