Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sfntedit] Ignore missing tables and continue #160

Closed
twardoch opened this issue Dec 21, 2016 · 0 comments
Closed

[sfntedit] Ignore missing tables and continue #160

twardoch opened this issue Dec 21, 2016 · 0 comments
Assignees
Labels

Comments

@twardoch
Copy link

@readroberts Currently, when I use sfntedit to extract or delete a series of tables, and specify some tables that don't exist in the font (e.g. I say sfntedit -d GPOS,GSUB font.ttf and the font does not have GSUB but only GPOS), sfntedit issues an error sfntedit [FATAL]: table missing (GSUB) and does not perform the operation at all. It would be useful to have an option -i (ignore errors) that would ignore these situations and still perform the operations on the other tables which do exist. I don't know enough C to patch sfntedit myself but I think it should be a relatively minor but useful thing.

@twardoch twardoch changed the title [wish] Make 'sfntedit' fail gracefully [wish] Make 'sfntedit' ignore missing tables and continue Dec 21, 2016
@miguelsousa miguelsousa changed the title [wish] Make 'sfntedit' ignore missing tables and continue [sfntedit] Ignore missing tables and continue Jul 2, 2018
@readroberts readroberts self-assigned this Aug 13, 2018
@miguelsousa miguelsousa assigned cjchapman and unassigned readroberts Feb 20, 2019
@readroberts readroberts assigned readroberts and unassigned cjchapman Feb 20, 2019
miguelsousa pushed a commit that referenced this issue Mar 14, 2019
Made changes to continue with a warning if a table is missing, and to not change the output file if no changes are made. If a table is missing, the exit code is still 0.

Fixes #160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants