Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tx] fail to convert multi-FD CFF2 font to CID-flavored CFF font #329

Closed
blueshade7 opened this issue Apr 20, 2018 · 1 comment
Closed
Assignees

Comments

@blueshade7
Copy link
Contributor

blueshade7 commented Apr 20, 2018

Run tx as:

tx -cff temp.cff # convert CFF2 with multi font dicts to CID/CFF font
tx -3 temp.cff # dump CID/CFF font

Result:
tx: --- temp.cff
tx: (cfr) source stream error
tx: fatal error

@blueshade7 blueshade7 self-assigned this Apr 20, 2018
blueshade7 added a commit that referenced this issue Apr 23, 2018
…CFF font

Initialize info.cid for each glyph in CID/CFF2 font with its gid, otherwise when converting CFF2 to CFF1, cfwAddGlyph regards all glyphs as CID = 0, optimize away all font dicts except font dict 0 for CID 0.
cjchapman pushed a commit that referenced this issue Apr 24, 2018
…CFF font

Initialize info.cid for each glyph in CID/CFF2 font with its gid, otherwise when converting CFF2 to CFF1, cfwAddGlyph regards all glyphs as CID = 0, optimize away all font dicts except font dict 0 for CID 0.
cjchapman pushed a commit that referenced this issue Apr 26, 2018
* fix for #329 [tx] fail to convert multi-FD CFF2 font to CID-flavored CFF font

Initialize info.cid for each glyph in CID/CFF2 font with its gid, otherwise when converting CFF2 to CFF1, cfwAddGlyph regards all glyphs as CID = 0, optimize away all font dicts except font dict 0 for CID 0.

* numtypes.h to include supportpublictypes.h

Also removed "l" from printf formatting strings for 32-bit integers

* fix spot win build

* Modified sfntedit to use sized int types

* Fixed sfntedit win build

* Modified sfntdiff to use supportpublictypes.h

also fixed header search path in XCode project setting

* fixed sfntdiff windows build

* simplified type definition of Fixed basing on Int32

this also fixes linux build of spot

* silenced Codacy errors/warnings
@blueshade7
Copy link
Contributor Author

Test font
SourceHanSans-Regular_cff2.otf.zip

schriftgestalt pushed a commit to schriftgestalt/afdko that referenced this issue May 18, 2019
…to CID-flavored CFF font

Initialize info.cid for each glyph in CID/CFF2 font with its gid, otherwise when converting CFF2 to CFF1, cfwAddGlyph regards all glyphs as CID = 0, optimize away all font dicts except font dict 0 for CID 0.
schriftgestalt pushed a commit to schriftgestalt/afdko that referenced this issue May 18, 2019
… any font (adobe-type-tools#342)

* fix for adobe-type-tools#329 [tx] fail to convert multi-FD CFF2 font to CID-flavored CFF font

Initialize info.cid for each glyph in CID/CFF2 font with its gid, otherwise when converting CFF2 to CFF1, cfwAddGlyph regards all glyphs as CID = 0, optimize away all font dicts except font dict 0 for CID 0.

* numtypes.h to include supportpublictypes.h

Also removed "l" from printf formatting strings for 32-bit integers

* fix spot win build

* Modified sfntedit to use sized int types

* Fixed sfntedit win build

* Modified sfntdiff to use supportpublictypes.h

also fixed header search path in XCode project setting

* fixed sfntdiff windows build

* simplified type definition of Fixed basing on Int32

this also fixes linux build of spot

* silenced Codacy errors/warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants