makeotf always exits with 0 (i.e. success) even when error occurs

[anthrotype]

The MakeOTF.py script's main() function does not return a non-zero value to the calling shell when an exception occurs and the font was not built successfully. Currently all exceptions are handled and passed, so main always exits successfully:

afdko/afdko/Tools/SharedData/FDKScripts/MakeOTF.py

Lines 3063 to 3073 in 56befef

	except (MakeOTFOptionsError, MakeOTFTXError, MakeOTFRunError):
	pass
	except Exception:
	import traceback
	traceback.print_exc()
	finally:
	if not makeOTFParams.debug:
	for tempPath in makeOTFParams.tempPathList:
	if os.path.exists(tempPath):
	os.remove(tempPath)
	print("Done.")

in fontmake there's an optional FDKFeatureCompiler that calls makeotf as subprocess. That code is broken for many reasons, one of which is that it attempts to guess whether the build was successful from the messages printed to stdout, because the exit code is meaningless.

[anthrotype]

(just realised I forgot an important "does not" in the previous message, so the logic was inverted; I edited the comment)

[miguelsousa]

@anthrotype fix done. Just waiting for your review